Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Capture more details during cluster assessment to provide deeper insights into impact analysis #1155

Closed
1 task done
Tracked by #1085
dmoore247 opened this issue Mar 28, 2024 · 4 comments
Labels
wontfix This will not be worked on

Comments

@dmoore247
Copy link
Contributor

dmoore247 commented Mar 28, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem statement

The $inventory.clusters table contains just ~6 fields of information while the cluster contains dozens of attributes.
Determining code compatibility depends on knowing more about the current compute cluster. If the code is already running on a UC (shared) compute platform, if is already running as a single user compute or job compute then the code block from the audit log can be dropped from interactive assessment dashboard.

For example:

  • data_security_mode will help eliminate false positives for clusters already converted or are of a Assigned type of cluster
  • Certain tags indicate the cluster is a job cluster
  • Cluster source will help identify clusters created via automation, possible job clusters

Proposed Solution

Adopt a "touch it, take it" approach when scanning clusters to satisfy future refinements to the assessment processes. (e.g. upgrade all clusters tagged with a certain department, group the assessment by a cluster tag to capture a group of workloads by business units)

Retain the existing $inventory.clusters table structure and columns for backwards compatibility.

Add an additional field into $inventory.clusters table, called attributes.
Within this table store the complex json obtained from the clusters api get method.

Ensure the attributes field can be queried using the SQL json notation for ease of use.

Additional Context

No response

@dmoore247 dmoore247 added enhancement New feature or request needs-triage labels Mar 28, 2024
@dmoore247 dmoore247 added this to UCX Mar 28, 2024
@github-project-automation github-project-automation bot moved this to Triage in UCX Mar 28, 2024
@nfx nfx added step/assessment go/uc/upgrade - Assessment Step and removed enhancement New feature or request labels Mar 28, 2024
@nfx
Copy link
Collaborator

nfx commented Mar 28, 2024

@dmoore247 this issue is not concrete enough - it cannot be distributed among people without context. Please split this issue up to a more granular ones and provide extremely detailed input.

@nfx
Copy link
Collaborator

nfx commented Apr 22, 2024

@vsevolodstep-db can you take a look at this issue, as it seems to align with your team's priorities

@nfx nfx removed the needs-triage label Apr 22, 2024
@nfx nfx moved this from Active Backlog to Design in UCX Apr 22, 2024
@nfx nfx added the migrate/code Abstract Syntax Trees and other dark magic label Apr 24, 2024
@nfx
Copy link
Collaborator

nfx commented Apr 24, 2024

place it in the same shared state that currently tracked database is. Also parse the DATABRICKS_RUNTIME_VERSION env var

@nfx nfx added wontfix This will not be worked on and removed step/assessment go/uc/upgrade - Assessment Step migrate/code Abstract Syntax Trees and other dark magic labels Apr 25, 2024
@nfx
Copy link
Collaborator

nfx commented Apr 25, 2024

No longer necessary

@nfx nfx closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2024
@github-project-automation github-project-automation bot moved this from Design to Archive in UCX Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
Archived in project
Development

No branches or pull requests

3 participants