Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Create Catalog Schema should validate external location #1101

Closed
1 task done
FastLee opened this issue Mar 25, 2024 · 0 comments · Fixed by #1110
Closed
1 task done

[FEATURE]: Create Catalog Schema should validate external location #1101

FastLee opened this issue Mar 25, 2024 · 0 comments · Fixed by #1110
Labels
cloud/aws Issues related to AWS cloud/azure issues related to Azure enhancement New feature or request migrate/external go/uc/upgrade SYNC EXTERNAL TABLES step migrate/managed go/uc/upgrade Upgrade Managed Tables and Jobs

Comments

@FastLee
Copy link
Contributor

FastLee commented Mar 25, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem statement

Currently create-catalog-schema doesn't validate the external location keyed in by the user and will fail if an erroneous location is keyed in.
Related:

Proposed Solution

Validate external locations before creating the catalog. Alert the user if the external location selected is not working.

Additional Context

No response

@FastLee FastLee added enhancement New feature or request migrate/external go/uc/upgrade SYNC EXTERNAL TABLES step migrate/managed go/uc/upgrade Upgrade Managed Tables and Jobs cloud/azure issues related to Azure cloud/aws Issues related to AWS labels Mar 25, 2024
@FastLee FastLee added this to UCX Mar 25, 2024
@github-project-automation github-project-automation bot moved this to Triage in UCX Mar 25, 2024
@nfx nfx closed this as completed in #1110 Mar 26, 2024
nfx pushed a commit that referenced this issue Mar 26, 2024
…e-catalogs-schemas` command (#1110)

In this release, we have updated the "create\_catalogs\_schemas"
function in "cli.py" to create UC catalogs and schemas based on the
destinations from "create\_table\_mapping". This function previously
used a "CatalogSchema" object created using the workspace client,
installation, and prompts, but has been modified to directly use the
installation object and call the "create\_all\_catalogs\_schemas"
method. We have also added a new feature for catalog validation with
commit message 'Feature/create catalog validation 1101', which includes
the addition of the "create\_all\_catalogs\_schemas" method in
"catalog\_schema.py". The new method generates a list of missing
catalogs and schemas and creates them using the "WorkspaceClient".
Additionally, we have added new imports, modified the constructor of the
"CatalogSchema" class, and added new methods for creating catalogs and
schemas, and updated the unit tests for
"hive\_metastore/catalog\_schema.py". Overall, these changes improve the
robustness and reliability of the tool for working with catalogs and
external locations.

Closes #1101
@github-project-automation github-project-automation bot moved this from Triage to Archive in UCX Mar 26, 2024
nkvuong pushed a commit that referenced this issue Mar 27, 2024
…e-catalogs-schemas` command (#1110)

In this release, we have updated the "create\_catalogs\_schemas"
function in "cli.py" to create UC catalogs and schemas based on the
destinations from "create\_table\_mapping". This function previously
used a "CatalogSchema" object created using the workspace client,
installation, and prompts, but has been modified to directly use the
installation object and call the "create\_all\_catalogs\_schemas"
method. We have also added a new feature for catalog validation with
commit message 'Feature/create catalog validation 1101', which includes
the addition of the "create\_all\_catalogs\_schemas" method in
"catalog\_schema.py". The new method generates a list of missing
catalogs and schemas and creates them using the "WorkspaceClient".
Additionally, we have added new imports, modified the constructor of the
"CatalogSchema" class, and added new methods for creating catalogs and
schemas, and updated the unit tests for
"hive\_metastore/catalog\_schema.py". Overall, these changes improve the
robustness and reliability of the tool for working with catalogs and
external locations.

Closes #1101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloud/aws Issues related to AWS cloud/azure issues related to Azure enhancement New feature or request migrate/external go/uc/upgrade SYNC EXTERNAL TABLES step migrate/managed go/uc/upgrade Upgrade Managed Tables and Jobs
Projects
Archived in project
1 participant