removed gdal python package as dependency in our python package #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 243 243
Lines 6675 6675
Branches 233 233
=======================================
Hits 6146 6146
Misses 529 529 |
|
OK, works on local, in here and on a 12.2 LTS cluster 🎉 |
milos-colic
approved these changes
Nov 17, 2023
|
|
milos-colic
approved these changes
Nov 29, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our python package setup currently fails if gdal natives don't already exist in the target environment. This PR addresses the issue by removing the dependency. Users are assumed to have run the init script before attempting to use any functions such as
RST_NDVIwhich call out to python to perform map algebra.