-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend replace database in query #210
Merged
nfx
merged 18 commits into
main
from
feat/replace-database-in-query-where-existing-database
Jul 11, 2024
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
06ee2e9
Specify which database to replace in query
JCZuurmond b4f938b
Merge tests
JCZuurmond 727a614
Refactor to replace database on dashboard metadata object
JCZuurmond 5d2d2f6
Let replace database return new instance of DashboardMetadata
JCZuurmond 42615ed
Support replacing catalog in dataset
JCZuurmond 30f674d
Add replace catalog functionality to create-dashboard command
JCZuurmond c566ea1
Move attribute docs
JCZuurmond c2800e1
Update integration test with new API
JCZuurmond 46de0bb
Add content to Tile
JCZuurmond a746993
Refactor DashboardMetadata to have tiles instead of tile metadata
JCZuurmond 3023afa
Make Tile content hidden
JCZuurmond b97a63c
Remove update from DashboardMetadata
JCZuurmond cc4ce27
Move replace_database to QueryTile
JCZuurmond 3c4ae39
Update command description
JCZuurmond 2cb6de7
Update docstring
JCZuurmond 26e24b9
Loop over tiles
JCZuurmond 9d8d374
Refactor TileMetadata.update to merge
JCZuurmond 2563c96
Add comment
JCZuurmond File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#214