Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support header for markdown files #161

Merged

Conversation

JCZuurmond
Copy link
Member

@JCZuurmond JCZuurmond commented Jun 17, 2024

Resolves #159

Screenshot 2024-06-17 at 14 28 54

  • Add unit tests
  • Add docs

@JCZuurmond JCZuurmond requested a review from nfx June 17, 2024 12:49
@JCZuurmond JCZuurmond self-assigned this Jun 17, 2024
@JCZuurmond JCZuurmond marked this pull request as ready for review June 17, 2024 15:14
Copy link

github-actions bot commented Jun 17, 2024

✅ 31/31 passed, 2 skipped, 8m25s total

Running from acceptance #198

Copy link
Member Author

@JCZuurmond JCZuurmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits

src/databricks/labs/lsql/dashboards.py Outdated Show resolved Hide resolved
src/databricks/labs/lsql/dashboards.py Outdated Show resolved Hide resolved
src/databricks/labs/lsql/dashboards.py Outdated Show resolved Hide resolved
JCZuurmond added a commit that referenced this pull request Jun 19, 2024
@JCZuurmond JCZuurmond changed the base branch from main to feat/dashboard-as-code-for-ucx June 19, 2024 06:44
@JCZuurmond JCZuurmond force-pushed the feat/support-header-for-markdown branch from f342561 to d7ae1fe Compare June 19, 2024 06:53
@JCZuurmond JCZuurmond merged commit 83b0a27 into feat/dashboard-as-code-for-ucx Jun 19, 2024
9 of 10 checks passed
@JCZuurmond JCZuurmond deleted the feat/support-header-for-markdown branch June 19, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support headers in markdown files
1 participant