[BUG] Dashboard/reformatted SQL queries are not verified before deployment #222
Assignees
Labels
bug
Something isn't working
Comments
nfx
pushed a commit
that referenced
this issue
Jul 22, 2024
Fixes the dashboard deployment by: - Raising an error when dashboard is invalid - Deprecating the `deploy_dashboard` for the `create_dashboard` as this is more accurate and available after refactoring Lakeview dashboard creation to be part of `DashboardMetadata` - Add `publish` flag to `create_dashboard` # Related issues - Resolves #222 - Resolves #229 - Partially resolves #220: leaves the return type to be discussed Below the dashboard created through the deprecated `deploy_dashboard`: 
nfx
added a commit
that referenced
this issue
Jul 22, 2024
* Fixed dashboard deployment/creation ([#230](#230)). The recent changes to our open-source library address issues related to dashboard deployment and creation, enhancing their reliability and consistency. The `deploy_dashboard` function has been deprecated in favor of the more accurate `create_dashboard` function, which now includes a `publish` flag. A `validate` method has been added to the `Tile`, `MarkdownTile`, and `QueryTile` classes to raise an error if the dashboard is invalid. The `test_dashboards.py` file has been updated to reflect these changes. These enhancements address issues [#222](#222), [#229](#229), and partially resolve [#220](#220). The commit includes an image of a dashboard created through the deprecated `deploy_dashboard` method. These improvements ensure better dashboard creation, validation, and deployment, while also maintaining backward compatibility through the deprecation of `deploy_dashboard`.
Merged
nfx
added a commit
that referenced
this issue
Jul 22, 2024
* Fixed dashboard deployment/creation ([#230](#230)). The recent changes to our open-source library address issues related to dashboard deployment and creation, enhancing their reliability and consistency. The `deploy_dashboard` function has been deprecated in favor of the more accurate `create_dashboard` function, which now includes a `publish` flag. A `validate` method has been added to the `Tile`, `MarkdownTile`, and `QueryTile` classes to raise an error if the dashboard is invalid. The `test_dashboards.py` file has been updated to reflect these changes. These enhancements address issues [#222](#222), [#229](#229), and partially resolve [#220](#220). The commit includes an image of a dashboard created through the deprecated `deploy_dashboard` method. These improvements ensure better dashboard creation, validation, and deployment, while also maintaining backward compatibility through the deprecation of `deploy_dashboard`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
incorrect SQL query may end up being in the dashboard, resulting in runtime errors
The text was updated successfully, but these errors were encountered: