Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECH DEBT] Dashboards class public methods have to work only with DashboardMetadata instances #212

Closed
JCZuurmond opened this issue Jul 10, 2024 · 1 comment · Fixed by #210
Closed

[TECH DEBT] Dashboards class public methods have to work only with DashboardMetadata instances #212

JCZuurmond opened this issue Jul 10, 2024 · 1 comment · Fixed by #210
Assignees
@JCZuurmond

Comments

@JCZuurmond
Copy link
Member

Dashboards class public methods have to work only with DashboardMetadata instances. we shouldn't leak any objects of lakeview or sdk in that class' public methods (edited)
@JCZuurmond JCZuurmond self-assigned this Jul 10, 2024
@JCZuurmond JCZuurmond mentioned this issue Jul 10, 2024
Merged
nfx pushed a commit that referenced this issue Jul 11, 2024
@JCZuurmond
Extend replace database in query (#210)
46875e7 
Improve the database replacement in query by:
- Making it part of the `DashboardMetadata` class
- Allow specifying which database to replace
- Support replacing catalog
- Allow specifying which catalog to replace

See
https://github.com/databrickslabs/ucx/pull/1920/files/fae429e4d73eceebd7259c9bcaa390e6c7aa4395#r1670960522

Partially resolves #212
@nfx nfx closed this as completed in #210 Jul 11, 2024
@JCZuurmond
Copy link
Member Author

Related to this to having a good signature for Dashboards class public method. Should the deploy_dashboard return the dashboard_id instead of the SDKDashboard:

    def deploy_dashboard(
        self,
        lakeview_dashboard: Dashboard,
        *,
        parent_path: str | None = None,
        dashboard_id: str | None = None,
        warehouse_id: str | None = None,
    ) -> SDKDashboard:

@JCZuurmond JCZuurmond mentioned this issue Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JCZuurmond JCZuurmond

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extend replace database in query databrickslabs/lsql
1 participant
@JCZuurmond