Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH DEBT] Extracting fields from query with * #110

Closed
Tracked by #106 ...
JCZuurmond opened this issue Jun 10, 2024 · 1 comment · Fixed by #201
Closed
Tracked by #106 ...

[TECH DEBT] Extracting fields from query with * #110

JCZuurmond opened this issue Jun 10, 2024 · 1 comment · Fixed by #201
Assignees

Comments

@JCZuurmond
Copy link
Member

JCZuurmond commented Jun 10, 2024

Let's say a user wants to visualize a table from the following query: SELECT * FROM table. What do we do in such a case?

Options:

  • raise an error with please specify explicit columns message

See extracting fields added in #111

@JCZuurmond JCZuurmond changed the title [TECH DEBT] [TECH DEBT] Extracting fields from query with * Jun 10, 2024
@JCZuurmond
Copy link
Member Author

@nfx : I am leaning towards logging a warning to user about the * and then trying to create a table with which ever columns are present next to the *. If there is only a * it will be an empty table.

Without database connection it will be impossible to infer the columns. Moreover, I want to nudge users to avoid using the *

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant