Update dashboard display name when updating dashboard in deploy (#186)

databrickslabs · Jun 21, 2024 · 553b007 · 553b007
1 parent 3d6677d
commit 553b007
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/databricks/labs/lsql/dashboards.py b/src/databricks/labs/lsql/dashboards.py
@@ -658,14 +658,15 @@ def deploy_dashboard(
     ) -> SDKDashboard:
         """Deploy a lakeview dashboard."""
         serialized_dashboard = json.dumps(lakeview_dashboard.as_dict())
+        display_name = lakeview_dashboard.pages[0].display_name or lakeview_dashboard.pages[0].name
         if dashboard_id is not None:
             dashboard = self._ws.lakeview.update(
                 dashboard_id,
+                display_name=display_name,
                 serialized_dashboard=serialized_dashboard,
                 warehouse_id=warehouse_id,
             )
         else:
-            display_name = lakeview_dashboard.pages[0].display_name or lakeview_dashboard.pages[0].name
             dashboard = self._ws.lakeview.create(
                 display_name,
                 parent_path=parent_path,

diff --git a/tests/unit/test_dashboards.py b/tests/unit/test_dashboards.py
@@ -968,11 +968,12 @@ def test_dashboards_deploy_calls_update_with_dashboard_id():
     dashboards = Dashboards(ws)
 
     dashboard = Dashboard([], [Page("test", [])])
-    dashboards.deploy_dashboard(dashboard, dashboard_id="test", warehouse_id="warehouse")
+    dashboards.deploy_dashboard(dashboard, dashboard_id="id", warehouse_id="warehouse")
 
     ws.lakeview.create.assert_not_called()
     ws.lakeview.update.assert_called_with(
-        "test",
+        "id",
+        display_name="test",
         serialized_dashboard=json.dumps({"pages": [{"name": "test"}]}),
         warehouse_id="warehouse",
     )