Skip to content

measure pre-aggregated metrics write latency #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2024
Merged

measure pre-aggregated metrics write latency #104

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87b8554
measure pre-aggregated metrics write latency
yuchen-db Nov 15, 2024
8b4e854
fix metric label name
yuchen-db Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions pkg/receive/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ const (
// Labels for metrics.
labelSuccess = "success"
labelError = "error"
labelPreAgg = "__rollup__"
)

type ReplicationProtocol string
Expand Down Expand Up @@ -226,9 +227,9 @@ func NewHandler(logger log.Logger, o *Options) *Handler {
Namespace: "thanos",
Subsystem: "receive",
Name: "write_e2e_latency_seconds",
Help: "The end-to-end latency of the oldest sample in write requests.",
Help: "The end-to-end latency of write requests.",
Buckets: []float64{1, 5, 10, 20, 30, 40, 50, 60, 90, 120, 300, 600, 900, 1200, 1800, 3600},
}, []string{"code", "tenant"},
}, []string{"code", "tenant", "rollup"},
),
}

Expand Down Expand Up @@ -484,16 +485,23 @@ func newWriteResponse(seriesIDs []int, err error, er endpointReplica) writeRespo
}
}

func secondsSinceOldestSample(toMS int64, ts prompb.TimeSeries) float64 {
func secondsSinceFirstSample(toMS int64, ts prompb.TimeSeries) float64 {
fromMS := toMS
for _, s := range ts.Samples {
if s.Timestamp < fromMS {
fromMS = s.Timestamp
}
if len(ts.Samples) > 0 {
fromMS = ts.Samples[0].Timestamp
}
return float64(toMS-fromMS) / 1000
}

func isPreAgged(ts prompb.TimeSeries) bool {
for _, l := range ts.Labels {
if l.Name == labelPreAgg && l.Value == "true" {
return true
}
}
return false
}

func (h *Handler) receiveHTTP(w http.ResponseWriter, r *http.Request) {
var err error
span, ctx := tracing.StartSpan(r.Context(), "receive_http")
Expand Down Expand Up @@ -640,8 +648,8 @@ func (h *Handler) receiveHTTP(w http.ResponseWriter, r *http.Request) {
}
nowMS := time.Now().UnixNano() / int64(time.Millisecond)
for _, ts := range wreq.Timeseries {
if lat := secondsSinceOldestSample(nowMS, ts); lat > 0 {
h.writeE2eLatency.WithLabelValues(strconv.Itoa(responseStatusCode), tenantHTTP).Observe(lat)
if lat := secondsSinceFirstSample(nowMS, ts); lat > 0 {
h.writeE2eLatency.WithLabelValues(strconv.Itoa(responseStatusCode), tenantHTTP, strconv.FormatBool(isPreAgged(ts))).Observe(lat)
}
}
}
Expand Down
Loading