[Exporter] improve handling of Emit/Add operations under the heavy load #4401
+20
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We may still have (theoretically) a race condition in `Add`/`Emit` operations due to the checks performed in separate functions, not directly in corresponding functions. This PR should prevent that theoretical possibility.
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mgyucht
approved these changes
Jan 24, 2025
mgyucht
added a commit
that referenced
this pull request
Jan 27, 2025
### New Features and Improvements * Add `no_compute` attribute to `databricks_app` ([#4364](#4364)). * Skip calling Read after Create/Update operations for `databricks_notebook` ([#4173](#4173)). ### Bug Fixes * Recreate `databricks_token` if it's not found or expired ([#4431](#4431)). * Handle empty response properly in `databricks_mws_workspaces` data source ([#4414](#4414)). * Recreate `databricks_obo_token` if it's removed or expired ([#4428](#4428)). ### Documentation * Added Queue Data Contributor role to Azure terraform docs ([#4412](#4412)). * Replaced references to data security mode with access mode ([#4408](#4408)). ### Internal Changes * Account for historical release headers when filtering on past changelog sections ([#4409](#4409)). * Introduce automated tagging ([#4366](#4366)). * Remove .extraheader config ([#4405](#4405)). * Remove tag signing in tagging.py script ([#4407](#4407)). * Set runs-on to use our internal runners ([#4403](#4403)). ### Dependency Updates * Bump Databricks Go SDK to v0.56.1 ([#4430](#4430)). * Bump github.com/hashicorp/terraform-plugin-go from 0.25.0 to 0.26.0 ([#4429](#4429)). * Bump github.com/hashicorp/terraform-plugin-mux from 0.17.0 to 0.18.0 ([#4432](#4432)). * Bump github.com/zclconf/go-cty from 1.16.1 to 1.16.2 ([#4423](#4423)). ### Exporter * **Breaking**: rename `workspace` service into `wsconf` ([#4425](#4425)). * Add listing for `databricks_permissions` so we can emit permissions for tokens ([#4402](#4402)). * Refactor jobs implementation to use only Go SDK ([#4380](#4380)). * improve handling of Emit/Add operations under the heavy load ([#4401](#4401)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
### New Features and Improvements * Add `no_compute` attribute to `databricks_app` ([#4364](#4364)). * Skip calling Read after Create/Update operations for `databricks_notebook` ([#4173](#4173)). ### Bug Fixes * Recreate `databricks_token` if it's not found or expired ([#4431](#4431)). * Handle empty response properly in `databricks_mws_workspaces` data source ([#4414](#4414)). * Recreate `databricks_obo_token` if it's removed or expired ([#4428](#4428)). ### Documentation * Added Queue Data Contributor role to Azure terraform docs ([#4412](#4412)). * Replaced references to data security mode with access mode ([#4408](#4408)). ### Internal Changes * Account for historical release headers when filtering on past changelog sections ([#4409](#4409)). * Introduce automated tagging ([#4366](#4366)). * Remove .extraheader config ([#4405](#4405)). * Remove tag signing in tagging.py script ([#4407](#4407)). * Set runs-on to use our internal runners ([#4403](#4403)). ### Dependency Updates * Bump Databricks Go SDK to v0.56.1 ([#4430](#4430)). * Bump github.com/hashicorp/terraform-plugin-go from 0.25.0 to 0.26.0 ([#4429](#4429)). * Bump github.com/hashicorp/terraform-plugin-mux from 0.17.0 to 0.18.0 ([#4432](#4432)). * Bump github.com/zclconf/go-cty from 1.16.1 to 1.16.2 ([#4423](#4423)). ### Exporter * **Breaking**: rename `workspace` service into `wsconf` ([#4425](#4425)). * Add listing for `databricks_permissions` so we can emit permissions for tokens ([#4402](#4402)). * Refactor jobs implementation to use only Go SDK ([#4380](#4380)). * improve handling of Emit/Add operations under the heavy load ([#4401](#4401)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We may still have (theoretically) a race condition in
Add/Emitoperations due to the checks performed in separate functions, not directly in corresponding functions. This PR should prevent that theoretical possibility.Tests
make testrun locallydocs/folderinternal/acceptance