Skip to content

[Fix] Add validation for run_as_mode in databricks_query #4233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexott merged 1 commit into from
Nov 16, 2024
Merged

[Fix] Add validation for run_as_mode in databricks_query #4233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/resources/query.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ The following arguments are available:
* `catalog` - (Optional, String) Name of the catalog where this query will be executed.
* `schema` - (Optional, String) Name of the schema where this query will be executed.
* `description` - (Optional, String) General description that conveys additional information about this query such as usage notes.
* `run_as_mode` - (Optional, String) Sets the "Run as" role for the object.
* `run_as_mode` - (Optional, String) Sets the "Run as" role for the object. Should be one of `OWNER`, `VIEWER`.
* `tags` - (Optional, List of strings) Tags that will be added to the query.
* `parameter` - (Optional, Block) Query parameter definition. Consists of following attributes (one of `*_value` is required):
* `name` - (Required, String) Literal parameter marker that appears between double curly braces in the query text.
Expand Down
4 changes: 1 addition & 3 deletions sql/resource_query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,7 @@ func (QueryStruct) CustomizeSchema(m *common.CustomizableSchema) *common.Customi
m.SchemaPath("warehouse_id").SetRequired().SetValidateFunc(validation.StringIsNotWhiteSpace)
m.SchemaPath("parent_path").SetCustomSuppressDiff(common.WorkspaceOrEmptyPathPrefixDiffSuppress).SetForceNew()
m.SchemaPath("owner_user_name").SetSuppressDiff()
m.SchemaPath("run_as_mode").SetSuppressDiff()
//m.SchemaPath("").SetSuppressDiff()
//m.SchemaPath("").SetSuppressDiff()
m.SchemaPath("run_as_mode").SetSuppressDiff().SetValidateFunc(validation.StringInSlice([]string{"VIEWER", "OWNER"}, false))
m.SchemaPath("id").SetReadOnly()
m.SchemaPath("create_time").SetReadOnly()
m.SchemaPath("lifecycle_state").SetReadOnly()
Expand Down