[Fix] Do not validate single node clusters if a policy is configured#4206
Closed
shreyas-goenka wants to merge 1 commit into
Closed
[Fix] Do not validate single node clusters if a policy is configured#4206shreyas-goenka wants to merge 1 commit into
shreyas-goenka wants to merge 1 commit into
Conversation
shreyas-goenka
requested review from
parthban-db
and removed request for
a team
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Test Details: go/deco-tests/11768949308 |
shreyas-goenka
commented
Nov 10, 2024
|
|
||
| // TODO: Remove this once all the resources using clusters are migrated to Go SDK. | ||
| // They would then be using Validate(cluster compute.CreateCluster) defined in resource_cluster.go that is a duplicate of this method but uses Go SDK. | ||
| func (cluster Cluster) Validate() error { |
Contributor
Author
There was a problem hiding this comment.
This function was not being used anywhere.
shreyas-goenka
changed the title
Contributor
|
@shreyas-goenka if required attributes will be filled via cluster policy, then there will be permanent configuration drift. See note in the doc |
Contributor
Author
|
Closing this PR in favour of #4222 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Addresses another problem reported in databricks/cli#1546, where customers were not able to configure and use cluster policies for single node clusters.
Tests
Unit tests, and manually verified that cluster is successfully created without spark_conf even when
num_workersis 0.