Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal] Change name with the aliases in codegen template #3904

Closed
wants to merge 2 commits into from
Closed

[Internal] Change name with the aliases in codegen template #3904

wants to merge 2 commits into from

Conversation

parthban-db
Copy link
Contributor

@parthban-db parthban-db commented Aug 14, 2024 •
edited
Loading

Changes

Change name with the aliases in codegen template.
Note: This PR will only generate the terraform provider when we release the databricks-sdk-go PR.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@parthban-db parthban-db requested review from a team as code owners August 14, 2024 15:00
@parthban-db parthban-db requested review from tanmay-db and edwardfeng-db and removed request for a team August 14, 2024 15:00
@parthban-db parthban-db changed the title Change name with the aliases in codegen template [Internal] Change name with the aliases in codegen template Aug 14, 2024
edwardfeng-db
edwardfeng-db approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@edwardfeng-db edwardfeng-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@parthban-db parthban-db changed the base branch from terraform-plugin-framework to main August 22, 2024 11:11
@parthban-db parthban-db changed the base branch from main to terraform-plugin-framework August 22, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardfeng-db edwardfeng-db edwardfeng-db approved these changes

@tanmay-db tanmay-db Awaiting requested review from tanmay-db tanmay-db is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parthban-db @edwardfeng-db