[Feature] Add `databricks_mws_network_connectivity_config` and `databricks_mws_network_connectivity_configs` data source by 840 · Pull Request #3665 · databricks/terraform-provider-databricks

840 · 2024-06-11T14:15:18Z

Changes

Add databricks_mws_network_connectivity_config & databricks_mws_network_connectivity_configs data source

Resolves #3614

Tests

make test run locally
relevant change in docs/ folder
covered with integration tests in internal/acceptance
relevant acceptance tests are passing
using Go SDK

codecov-commenter · 2024-06-11T14:19:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.62%. Comparing base (f1cebcb) to head (caacadc).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3665      +/-   ##
==========================================
+ Coverage   81.59%   81.62%   +0.02%     
==========================================
  Files         196      197       +1     
  Lines       19739    19764      +25     
==========================================
+ Hits        16107    16132      +25     
  Misses       2672     2672              
  Partials      960      960

Files	Coverage Δ
mws/data_mws_network_connectivity_config.go	`100.00% <100.00%> (ø)`
provider/provider.go	`93.99% <100.00%> (+0.02%)`	⬆️

840 · 2024-06-11T16:10:33Z

I have trouble running the acceptance test on an account-level locally. Will reply back when I'm able to make it work

alexott

We need to discuss the use case for this implementation...

840 · 2024-06-21T13:46:37Z

The OpenAPI spec for NetworkConnectivityConfiguration is out-of-date. I have to wait until it is fixed before I can continue. I have already reported this to the respective team.

…lid OpenAPI spec)

…ws_network_connectivity_configs`

840 · 2024-11-15T10:17:13Z

I noticed an issue with regions for acceptance tests; those are different depending on the cloud. Will look into it.

github-actions · 2024-11-15T18:33:45Z

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

PR number: 3665
Commit SHA: 8da44b280a44a3fffab1cf58855bbcc7d72900ed

Checks will be approved automatically on success.

eng-dev-ecosystem-bot · 2024-11-15T18:34:06Z

Test Details: go/deco-tests/11861593549

### New Features and Improvements * Add `databricks_mws_network_connectivity_config` and `databricks_mws_network_connectivity_configs` data source ([#3665](#3665)). * Add support partitions in policy data sources ([#4181](#4181)). * Added `databricks_registered_model_versions` data source ([#4100](#4100)). * Update databricks_permissions resource to support vector-search-endpoints ([#4209](#4209)). * add `databricks_serving_endpoints` data source ([#4226](#4226)). ### Bug Fixes * Add validation for `run_as_mode` in `databricks_query` ([#4233](#4233)). * Correct handling of updates for empty comments and `force_destroy` in UC catalog, schema, registered models and volumes ([#4244](#4244)). * Fix deletion of dashboard if it was trashed out of band ([#4235](#4235)). * Fix waiting for `databricks_vector_search_index` readiness ([#4243](#4243)). * Remove single-node validation from interactive clusters ([#4222](#4222)). * Remove single-node validation from jobs clusters ([#4216](#4216)). * Use cluster list API to determine pinned cluster status ([#4203](#4203)). * fix issue cased by setting pause_status in update monitor ([#4242](#4242)). ### Documentation * Clarify workspace provider config ([#4208](#4208)). * Update "Databricks Workspace Creator" permissions on gcp-workspace.md ([#4201](#4201)). * Update `grants.md` references ([#4246](#4246)). * Update description of `group_id` in `databricks_mws_ncc_private_endpoint_rule` ([#4238](#4238)). * remove subnet sharing limitation in AWS ([#4239](#4239)). ### Internal Changes * Bump Go SDK to latest and generate TF structs ([#4249](#4249)). * Mark TestUcAccModelServingProvisionedThroughput as flaky. to be rever… ([#4232](#4232)). * Rename resources directory to products in pluginframework ([#4139](#4139)). * Revert "mark TestUcAccModelServingProvisionedThroughput as flaky. to … ([#4240](#4240)). * Set user agent in some resources implemented in plugin framework ([#4187](#4187)). * make `ApplyAndExpectData` work with nested set ([#4237](#4237)). ### Dependency Updates * Bump dependencies for Plugin Framework and SDK v2 ([#4215](#4215)). * Bump github.com/hashicorp/hcl/v2 from 2.22.0 to 2.23.0 ([#4236](#4236)). * Bump github.com/hashicorp/terraform-plugin-testing from 1.10.0 to 1.11.0 ([#4247](#4247)). ### Exporter * Add `List` operation for `users` service ([#4204](#4204)). * Fix interactive selection of services ([#4245](#4245)).

* Add `databricks_mws_network_connectivity_config` and `databricks_mws_network_connectivity_configs` data source ([#3665](#3665)). * Add support partitions in policy data sources ([#4181](#4181)). * Added `databricks_registered_model_versions` data source ([#4100](#4100)). * Update databricks_permissions resource to support vector-search-endpoints ([#4209](#4209)). * add `databricks_serving_endpoints` data source ([#4226](#4226)). * Add validation for `run_as_mode` in `databricks_query` ([#4233](#4233)). * Correct handling of updates for empty comments and `force_destroy` in UC catalog, schema, registered models and volumes ([#4244](#4244)). * Fix deletion of dashboard if it was trashed out of band ([#4235](#4235)). * Fix waiting for `databricks_vector_search_index` readiness ([#4243](#4243)). * Remove single-node validation from interactive clusters ([#4222](#4222)). * Remove single-node validation from jobs clusters ([#4216](#4216)). * Use cluster list API to determine pinned cluster status ([#4203](#4203)). * fix issue cased by setting pause_status in update monitor ([#4242](#4242)). * Clarify workspace provider config ([#4208](#4208)). * Update "Databricks Workspace Creator" permissions on gcp-workspace.md ([#4201](#4201)). * Update `grants.md` references ([#4246](#4246)). * Update description of `group_id` in `databricks_mws_ncc_private_endpoint_rule` ([#4238](#4238)). * remove subnet sharing limitation in AWS ([#4239](#4239)). * Bump Go SDK to latest and generate TF structs ([#4249](#4249)). * Mark TestUcAccModelServingProvisionedThroughput as flaky. to be rever… ([#4232](#4232)). * Rename resources directory to products in pluginframework ([#4139](#4139)). * Revert "mark TestUcAccModelServingProvisionedThroughput as flaky. to … ([#4240](#4240)). * Set user agent in some resources implemented in plugin framework ([#4187](#4187)). * make `ApplyAndExpectData` work with nested set ([#4237](#4237)). * Bump dependencies for Plugin Framework and SDK v2 ([#4215](#4215)). * Bump github.com/hashicorp/hcl/v2 from 2.22.0 to 2.23.0 ([#4236](#4236)). * Bump github.com/hashicorp/terraform-plugin-testing from 1.10.0 to 1.11.0 ([#4247](#4247)). * Add `List` operation for `users` service ([#4204](#4204)). * Fix interactive selection of services ([#4245](#4245)).

### New Features and Improvements * Add `databricks_mws_network_connectivity_config` and `databricks_mws_network_connectivity_configs` data source ([#3665](#3665)). * Add support partitions in policy data sources ([#4181](#4181)). * Added `databricks_registered_model_versions` data source ([#4100](#4100)). * Update databricks_permissions resource to support vector-search-endpoints ([#4209](#4209)). * add `databricks_serving_endpoints` data source ([#4226](#4226)). ### Bug Fixes * Add validation for `run_as_mode` in `databricks_query` ([#4233](#4233)). * Correct handling of updates for empty comments and `force_destroy` in UC catalog, schema, registered models and volumes ([#4244](#4244)). * Fix deletion of dashboard if it was trashed out of band ([#4235](#4235)). * Fix waiting for `databricks_vector_search_index` readiness ([#4243](#4243)). * Remove single-node validation from interactive clusters ([#4222](#4222)). * Remove single-node validation from jobs clusters ([#4216](#4216)). * Use cluster list API to determine pinned cluster status ([#4203](#4203)). * fix issue cased by setting pause_status in update monitor ([#4242](#4242)). ### Documentation * Clarify workspace provider config ([#4208](#4208)). * Update "Databricks Workspace Creator" permissions on gcp-workspace.md ([#4201](#4201)). * Update `grants.md` references ([#4246](#4246)). * Update description of `group_id` in `databricks_mws_ncc_private_endpoint_rule` ([#4238](#4238)). * remove subnet sharing limitation in AWS ([#4239](#4239)). ### Internal Changes * Bump Go SDK to latest and generate TF structs ([#4249](#4249)). * Mark TestUcAccModelServingProvisionedThroughput as flaky. to be rever… ([#4232](#4232)). * Rename resources directory to products in pluginframework ([#4139](#4139)). * Revert "mark TestUcAccModelServingProvisionedThroughput as flaky. to … ([#4240](#4240)). * Set user agent in some resources implemented in plugin framework ([#4187](#4187)). * make `ApplyAndExpectData` work with nested set ([#4237](#4237)). ### Dependency Updates * Bump dependencies for Plugin Framework and SDK v2 ([#4215](#4215)). * Bump github.com/hashicorp/hcl/v2 from 2.22.0 to 2.23.0 ([#4236](#4236)). * Bump github.com/hashicorp/terraform-plugin-testing from 1.10.0 to 1.11.0 ([#4247](#4247)). ### Exporter * Add `List` operation for `users` service ([#4204](#4204)). * Fix interactive selection of services ([#4245](#4245)).

Add databricks_mws_network_connectivity_config data source

caacadc

840 requested review from a team as code owners June 11, 2024 14:15

840 requested review from hectorcast-db and removed request for a team June 11, 2024 14:15

Add acceptance test and run make fmt

65182fe

840 changed the title ~~[WIP] Add databricks_mws_network_connectivity_config data source~~ Add databricks_mws_network_connectivity_config data source Jun 11, 2024

alexott requested changes Jun 12, 2024

View reviewed changes

840 marked this pull request as draft June 12, 2024 16:38

840 changed the title ~~Add databricks_mws_network_connectivity_config data source~~ [WIP] Add databricks_mws_network_connectivity_config data source Jun 12, 2024

mgyucht reviewed Jul 9, 2024

View reviewed changes

Comment thread mws/data_mws_network_connectivity_config.go Outdated

840 added 3 commits July 22, 2024 17:46

Add support for name or regional lookup (still broken because of inva…

a8bdb4d

…lid OpenAPI spec)

Merge remote-tracking branch 'origin/master' into issue-3614

abbab65

Merge branch 'main' into issue-3614

3f1e078

840 temporarily deployed to test-trigger-is November 14, 2024 09:43 — with GitHub Actions Inactive

Fix databricks_mws_network_connectivity_config

b19259f

840 temporarily deployed to test-trigger-is November 14, 2024 20:37 — with GitHub Actions Inactive

Fix tests for databricks_mws_network_connectivity_config

fd59501

840 temporarily deployed to test-trigger-is November 14, 2024 20:38 — with GitHub Actions Inactive

fmt

c6f5768

840 temporarily deployed to test-trigger-is November 14, 2024 20:40 — with GitHub Actions Inactive

Finish databricks_mws_network_connectivity_config and `databricks_m…

0711747

…ws_network_connectivity_configs`

840 temporarily deployed to test-trigger-is November 14, 2024 22:23 — with GitHub Actions Inactive

840 changed the title ~~[WIP] Add databricks_mws_network_connectivity_config data source~~ [WIP] Add databricks_mws_network_connectivity_config and databricks_mws_network_connectivity_configs data source Nov 14, 2024

Add docs

c502706

840 temporarily deployed to test-trigger-is November 15, 2024 09:53 — with GitHub Actions Inactive

840 changed the title ~~[WIP] Add databricks_mws_network_connectivity_config and databricks_mws_network_connectivity_configs data source~~ Add databricks_mws_network_connectivity_config and databricks_mws_network_connectivity_configs data source Nov 15, 2024

840 changed the title ~~Add databricks_mws_network_connectivity_config and databricks_mws_network_connectivity_configs data source~~ [Feature] Add databricks_mws_network_connectivity_config and databricks_mws_network_connectivity_configs data source Nov 15, 2024

Merge branch 'main' into issue-3614

cfcdc42

840 temporarily deployed to test-trigger-is November 15, 2024 09:57 — with GitHub Actions Inactive

840 marked this pull request as ready for review November 15, 2024 10:08

alexott approved these changes Nov 15, 2024

View reviewed changes

Merge branch 'main' into issue-3614

3fc5c57

alexott temporarily deployed to test-trigger-is November 15, 2024 18:26 — with GitHub Actions Inactive

Parametrize region settings by cloud

8da44b2

alexott temporarily deployed to test-trigger-is November 15, 2024 18:34 — with GitHub Actions Inactive

alexott enabled auto-merge November 15, 2024 19:39

alexott added this pull request to the merge queue Nov 15, 2024

Merged via the queue into databricks:main with commit 5396981 Nov 15, 2024

hectorcast-db mentioned this pull request Nov 20, 2024

[Release] Release v1.59.0 #4252

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] Add `databricks_mws_network_connectivity_config` and `databricks_mws_network_connectivity_configs` data source#3665

[Feature] Add `databricks_mws_network_connectivity_config` and `databricks_mws_network_connectivity_configs` data source#3665
alexott merged 13 commits into
databricks:mainfrom
840:issue-3614

840 commented Jun 11, 2024 •

edited

Loading

Uh oh!

codecov-commenter commented Jun 11, 2024

Uh oh!

840 commented Jun 11, 2024

Uh oh!

alexott left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

840 commented Jun 21, 2024

Uh oh!

Uh oh!

840 commented Nov 15, 2024

Uh oh!

github-actions Bot commented Nov 15, 2024

Uh oh!

eng-dev-ecosystem-bot commented Nov 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

840 commented Jun 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Tests

Uh oh!

codecov-commenter commented Jun 11, 2024

Codecov Report

Uh oh!

840 commented Jun 11, 2024

Uh oh!

alexott left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

840 commented Jun 21, 2024

Uh oh!

Uh oh!

840 commented Nov 15, 2024

Uh oh!

github-actions Bot commented Nov 15, 2024

Uh oh!

eng-dev-ecosystem-bot commented Nov 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

840 commented Jun 11, 2024 •

edited

Loading