Skip to content
This repository was archived by the owner on Mar 24, 2025. It is now read-only.

Conversation

@HyukjinKwon
Copy link
Member

No description provided.

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Dec 30, 2018

BTW, I faced an issue that Scala version suffixes are missing. I think I always followed the current procedures so far if I am not mistaken so I suspect it's an issue somewhere.

For 0.5.0 release, I had to make some minor fixes in build.sbt.

I'm going to fix the script when next release is to be done later if I need to fix something else.

@codecov-io
Copy link

codecov-io commented Dec 30, 2018

Codecov Report

Merging #371 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #371   +/-   ##
=======================================
  Coverage   87.48%   87.48%           
=======================================
  Files          14       14           
  Lines         735      735           
  Branches       90       90           
=======================================
  Hits          643      643           
  Misses         92       92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a712ea...6cf16f2. Read the comment docs.

@srowen
Copy link
Collaborator

srowen commented Dec 30, 2018

This makes sense. Yes, I was afraid that the several changes I made to the build script might have caused an issue at release time. I think the issue here is crossPaths. When false, it seems like the Java test suite is not run. Changing it to true looked like the recommended fix, but the flag really is about building separate outputs for different Scala versions. https://www.scala-sbt.org/1.0/docs/Basic-Def-Examples.html

If the issue is only that there is target/scala instead of target/scala-2.11 then maybe the answer is to build separately for 2.11 and 2.12 or something.

Or you can just set this to false if it corrects the problem and we'll later find a different way to run the Java suite.

Or maybe that wasn't the problem you are seeing.

@HyukjinKwon
Copy link
Member Author

Yea, those stuff were what I faced. Let me get rid of crossPaths for now.

@HyukjinKwon
Copy link
Member Author

I just released it and tested this script.

@HyukjinKwon HyukjinKwon merged commit c1af25e into databricks:master Dec 30, 2018
crossScalaVersions := Seq("2.11.12", "2.12.8")

// Necessary for JUnit tests to be found?
crossPaths := false
Copy link
Member Author

@HyukjinKwon HyukjinKwon Dec 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I at least see being ran fine in Travis CI ...

[info] Test com.databricks.spark.xml.JavaXmlSuite.testLoad started
[info] Test com.databricks.spark.xml.JavaXmlSuite.testSave started
[info] Test com.databricks.spark.xml.JavaXmlSuite.testXmlParser started

should not be a big deal .. I guess ..

@srowen
Copy link
Collaborator

srowen commented Dec 30, 2018

Ok that's good. Either I made a mistake or something else was actually the fix. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants