Clarify each argument in each line, two lines limit and add invocation style guide#64
Merged
rxin merged 2 commits intodatabricks:masterfrom Jun 4, 2018
Merged
Conversation
Member
Author
|
Hi @rxin and @jkbradley. I intendedly didn't add examples when it fits in two lines, for example: because I actually see many variants, for example: within Spark and started to worry if we should force it. Please let me know if we should add this too, or if I missed the intention in #58. |
|
Not sure. I was taught this by @mengxr and have tried to enforce it in MLlib. Maybe other parts of Spark differ. |
Member
Author
|
@rxin, WDYT about this? |
rxin
reviewed
Jun 1, 2018
rxin
reviewed
Jun 1, 2018
rxin
reviewed
Jun 1, 2018
HyukjinKwon
commented
Jun 4, 2018
Contributor
|
Thanks - merging. You don't know Chinese, do you ? :p |
Contributor
|
cc @Hawstein do you have time to submit a patch to reflect this update? |
Contributor
|
@rxin Of course, will do it today when I have time. |
Hawstein
added a commit
to Hawstein/scala-style-guide
that referenced
this pull request
Jun 6, 2018
rxin
pushed a commit
that referenced
this pull request
May 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR clarifies each argument in each line, two lines limit and adds invocation style guide in "Spacing and Indentation".