Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix is_unique to respect the current Spark column #981

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Oct 30, 2019

No description provided.

@ueshin ueshin requested a review from HyukjinKwon October 30, 2019 21:49
@softagram-bot
Copy link

Softagram Impact Report for pull/981 (head commit: d556aa5)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Impact Report explained. Give feedback on this report to support@softagram.com

@codecov-io
Copy link

codecov-io commented Oct 30, 2019

Codecov Report

Merging #981 into master will increase coverage by 1.49%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #981      +/-   ##
==========================================
+ Coverage   93.24%   94.74%   +1.49%     
==========================================
  Files          34       34              
  Lines        6487     6486       -1     
==========================================
+ Hits         6049     6145      +96     
+ Misses        438      341      -97
Impacted Files Coverage Δ
databricks/koalas/series.py 96.32% <100%> (-0.01%) ⬇️
databricks/conftest.py 97.87% <0%> (+4.25%) ⬆️
databricks/koalas/__init__.py 85.36% <0%> (+7.31%) ⬆️
databricks/koalas/usage_logging/usage_logger.py 100% <0%> (+50%) ⬆️
databricks/koalas/usage_logging/__init__.py 97.27% <0%> (+72.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f228961...d556aa5. Read the comment docs.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice. LGTM

@HyukjinKwon HyukjinKwon changed the title Fix is_unique. Fix is_unique to respect the current Spark column Oct 31, 2019
@HyukjinKwon HyukjinKwon merged commit a7dc3b1 into databricks:master Oct 31, 2019
@ueshin ueshin deleted the is_unique branch October 31, 2019 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants