-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add datetime as the equivalent python type to TimestampType #957
Conversation
Do I need to write a test? |
@harupy i'm not sure but maybe it should be better in terms of usecase example? 😸 |
Codecov Report
@@ Coverage Diff @@
## master #957 +/- ##
==========================================
- Coverage 94.52% 93.07% -1.45%
==========================================
Files 34 34
Lines 6466 6487 +21
==========================================
- Hits 6112 6038 -74
- Misses 354 449 +95
Continue to review full report at Codecov.
|
@itholic Thanks for the comment. I'll wait for them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, let's add a simple test. It's a good practice to add a test whenever it's possible anyway :-).
@HyukjinKwon Ok, I'll add a test. |
I'm thinking of adding the following code to def tomorrow(date) -> datetime:
return date + timedelta(days=1)
test_df = ks.DataFrame([datetime(2019, 10, 24)], columns=['date'])
test_df['date'] = test_df['date'].map(tomorrow) |
Sounds good! |
Softagram Impact Report for pull/957 (head commit: 5e01044)⭐ Change Overview
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
@HyukjinKwon test passed |
Thanks, @harupy |
Resolves #951