Introduce column_scols in InternalFrame substitude for data_columns. #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
great work! maybe would it be better to pause my underway works until this PR will be merged? |
Codecov Report
@@ Coverage Diff @@
## master #956 +/- ##
==========================================
- Coverage 94.83% 92.36% -2.48%
==========================================
Files 34 34
Lines 6640 6652 +12
==========================================
- Hits 6297 6144 -153
- Misses 343 508 +165
Continue to review full report at Codecov.
|
ueshin
changed the title
HyukjinKwon
reviewed
Oct 29, 2019
| @@ -381,10 +381,10 @@ class _InternalFrame(object): | |||
|
|
|||
| def __init__(self, sdf: spark.DataFrame, | |||
| index_map: Optional[List[IndexMap]] = None, | |||
| scol: Optional[spark.Column] = None, | |||
| data_columns: Optional[List[str]] = None, | |||
HyukjinKwon
approved these changes
Oct 29, 2019
ueshin
changed the title
Softagram Impact Report for pull/956 (head commit: 5aa74b7)⭐ Change Overview
⭐ Details of Dependency Changes
💡 Insights
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
HyukjinKwon
changed the title
|
Test failure seems unrelated. I will track and fix separately. |
HyukjinKwon
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.