-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Series.keys #935
Conversation
Codecov Report
@@ Coverage Diff @@
## master #935 +/- ##
==========================================
+ Coverage 94.46% 94.46% +<.01%
==========================================
Files 34 34
Lines 6382 6383 +1
==========================================
+ Hits 6029 6030 +1
Misses 353 353
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ueshin @HyukjinKwon i think they have different behavior about showing index as print out, in python3.7 Expected:
MultiIndex([( 'lama', 'speed'),
( 'lama', 'weight'),
( 'lama', 'length'),
( 'cow', 'speed'),
( 'cow', 'weight'),
( 'cow', 'length'),
('falcon', 'speed'),
('falcon', 'weight'),
('falcon', 'length')],
) but python3.5 & python3.6 Got:
MultiIndex(levels=[['cow', 'falcon', 'lama'], ['length', 'speed', 'weight']],
labels=[[2, 2, 2, 0, 0, 0, 1, 1, 1], [1, 2, 0, 1, 2, 0, 1, 2, 0]]) so the doctest raises error, any idea how to fix this? i think maybe we can just skip doctest or remove examples from doctest |
@itholic Let's keep the 3.7 result and skip the doctest. |
@ueshin i think it's better too. thanks for your comment!! |
Softagram Impact Report for pull/935 (head commit: 6426262)⭐ Change Overview
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
An alias for index.