Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update and add tests for update and join. #848

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Oct 1, 2019

No description provided.

@ueshin ueshin requested a review from HyukjinKwon October 1, 2019 00:06
@softagram-bot
Copy link

Softagram Impact Report for pull/848 (head commit: 85d257e)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Impact Report explained. Give feedback on this report to [email protected]

@codecov-io
Copy link

codecov-io commented Oct 1, 2019

Codecov Report

Merging #848 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #848      +/-   ##
==========================================
+ Coverage   94.17%   94.17%   +<.01%     
==========================================
  Files          32       32              
  Lines        6007     6008       +1     
==========================================
+ Hits         5657     5658       +1     
  Misses        350      350
Impacted Files Coverage Δ
databricks/koalas/frame.py 96.09% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 391df25...85d257e. Read the comment docs.

@HyukjinKwon
Copy link
Member

Hmmm .I might have to add a retry logic at:


  File "/home/travis/build/databricks/koalas/docs/source/../../dev/gendoc.py", line 195, in download_pandoc_if_needed
    pandoc_download.download_pandoc(targetfolder=path)
  File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/pypandoc/pandoc_download.py", line 190, in download_pandoc
...
    raise URLError(err)
urllib.error.URLError: <urlopen error [Errno 110] Connection timed out>
* Downloading pandoc from https://github.com/jgm/pandoc/releases/download/2.7.3/pandoc-2.7.3-1-amd64.deb ...
Makefile:21: recipe for target 'html' failed

retriggering..

@ueshin
Copy link
Collaborator Author

ueshin commented Oct 1, 2019

Thanks! merging.

@ueshin ueshin merged commit cf22a5d into databricks:master Oct 1, 2019
@ueshin ueshin deleted the update branch October 1, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants