Generate "Release Notes" in official documentation #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
commented
Sep 28, 2019
HyukjinKwon
force-pushed
the
generate-release-docs
branch
from
c9c2e0c to
c633d92
Compare
HyukjinKwon
commented
Sep 29, 2019
| release_file.write("\n") | ||
|
|
||
|
|
||
| def download_pandoc_if_needed(path): |
There was a problem hiding this comment.
This whole function was basically just ported from pypandoc with some minor changes, in order to:
- check if already downloaded
- to patch
https://github.com/bebraw/pypandoc/pull/154
rxin
approved these changes
Sep 29, 2019
Codecov Report
@@ Coverage Diff @@
## master #842 +/- ##
=======================================
Coverage 94.31% 94.31%
=======================================
Files 32 32
Lines 5930 5930
=======================================
Hits 5593 5593
Misses 337 337Continue to review full report at Codecov.
|
Softagram Impact Report for pull/842 (head commit: bf4d78c)⭐ Change Overview
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
|
Thanks! For 10 minutes koalas as a doc, I will do it in a separate PR @ueshin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to generate "Release Notes" from https://github.com/databricks/koalas/releases
Basically, it gets the release MD text from the URL, converts it into rst file via
pandoc(withpypandoc).Reference: https://pandas.pydata.org/pandas-docs/stable/whatsnew/index.html#
Seems like working fine as below: