-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DataFrame.pop #791
Conversation
Codecov Report
@@ Coverage Diff @@
## master #791 +/- ##
=========================================
+ Coverage 94.3% 94.3% +<.01%
=========================================
Files 32 32
Lines 5828 5831 +3
=========================================
+ Hits 5496 5499 +3
Misses 332 332
Continue to review full report at Codecov.
|
Softagram Impact Report for pull/791 (head commit: 0ba5c19)⭐ Change Overview
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks! merging. |
@ueshin Thanks :) |
Resolves #788
like pandas.DataFrame.pop (https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.pop.html?highlight=pop#pandas.DataFrame.pop) now we can pop column from koalas DataFrame like below:
(use pandas.DataFrame.pop example)
Unlike pandas, we should remove column information via internal frame.
and when we remove column from internal frame, maybe we should remove related metadata also (like _data_columns, _column_index ...).