Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tests for datetime & Remove unsupported property #729

Merged
merged 2 commits into from
Sep 2, 2019

Conversation

itholic
Copy link
Contributor

@itholic itholic commented Aug 31, 2019

Add missing test for weekday
스크린샷 2019-08-31 오후 3 01 12

Remove unsupported property millisecond for Series Datetime Properties.

스크린샷 2019-08-31 오후 2 49 55

@itholic itholic changed the title Add missing tests for datatime & Remove unsupported property Add missing tests for datetime & Remove unsupported property Aug 31, 2019
@softagram-bot
Copy link

Softagram Impact Report for pull/729 (head commit: 0e87b72)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Impact Report explained. Give feedback on this report to [email protected]

@codecov-io
Copy link

codecov-io commented Aug 31, 2019

Codecov Report

Merging #729 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #729      +/-   ##
==========================================
+ Coverage   94.19%   94.23%   +0.03%     
==========================================
  Files          32       32              
  Lines        5567     5564       -3     
==========================================
- Hits         5244     5243       -1     
+ Misses        323      321       -2
Impacted Files Coverage Δ
databricks/koalas/datetimes.py 98.23% <ø> (+1.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4228bad...0e87b72. Read the comment docs.

"""
The milliseconds of the datetime.
"""
return _wrap_accessor_pandas(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we remove this? Does this not work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HyukjinKwon, Thanks to Review.
I thought these were the reuses of the Pandas Series dt Property.
However, in the screenshots I added to PR, the Pandas Series dt Property does not support milliseconds.
So I thought this was probably added by mistake.
And It doesn't actually work as you asked, (as in the following screenshot.)

스크린샷 2019-09-01 오후 2 06 51

@HyukjinKwon HyukjinKwon merged commit 5a6bbb9 into databricks:master Sep 2, 2019
@itholic itholic deleted the test_for_datetimes branch September 6, 2019 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants