-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration value: compute.max_rows #721
Conversation
Codecov Report
@@ Coverage Diff @@
## master #721 +/- ##
==========================================
- Coverage 94.27% 94.16% -0.11%
==========================================
Files 32 32
Lines 5572 5573 +1
==========================================
- Hits 5253 5248 -5
- Misses 319 325 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise
@HyukjinKwon Thanks, I've resolved all you commented. |
@itholic, can you resolve conflicts and rebase this? I will merge. |
@HyukjinKwon , Resolved conflicts. Thanks ! |
Softagram Impact Report for pull/721 (head commit: d0aae42)⭐ Change Overview
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
related with #718 i added compute.max_rows