Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration value: compute.max_rows #721

Merged
merged 8 commits into from
Sep 2, 2019

Conversation

itholic
Copy link
Contributor

@itholic itholic commented Aug 30, 2019

related with #718 i added compute.max_rows

@codecov-io
Copy link

codecov-io commented Aug 30, 2019

Codecov Report

Merging #721 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #721      +/-   ##
==========================================
- Coverage   94.27%   94.16%   -0.11%     
==========================================
  Files          32       32              
  Lines        5572     5573       +1     
==========================================
- Hits         5253     5248       -5     
- Misses        319      325       +6
Impacted Files Coverage Δ
databricks/koalas/config.py 100% <ø> (ø) ⬆️
databricks/koalas/frame.py 94.72% <100%> (-0.15%) ⬇️
databricks/koalas/plot.py 93.78% <0%> (-1.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ba4bc4...d0aae42. Read the comment docs.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise

@itholic
Copy link
Contributor Author

itholic commented Aug 31, 2019

@HyukjinKwon Thanks, I've resolved all you commented.

@HyukjinKwon
Copy link
Member

@itholic, can you resolve conflicts and rebase this? I will merge.

@itholic
Copy link
Contributor Author

itholic commented Sep 2, 2019

@HyukjinKwon , Resolved conflicts. Thanks !

@softagram-bot
Copy link

Softagram Impact Report for pull/721 (head commit: d0aae42)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Impact Report explained. Give feedback on this report to [email protected]

@HyukjinKwon HyukjinKwon merged commit 4618def into databricks:master Sep 2, 2019
@itholic itholic deleted the add_config2 branch September 2, 2019 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants