Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing tests for namespace #711

Merged
merged 2 commits into from
Aug 29, 2019

Conversation

itholic
Copy link
Contributor

@itholic itholic commented Aug 29, 2019

I found some untested codes in namespace.py like:

스크린샷 2019-08-29 오후 1 37 49

스크린샷 2019-08-29 오후 1 38 07

스크린샷 2019-08-29 오후 1 38 15

스크린샷 2019-08-29 오후 1 38 47

so i added tests for cover them.

I would appreciate it if someone available.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@HyukjinKwon
Copy link
Member

Looks good if tests pass

@codecov-io
Copy link

codecov-io commented Aug 29, 2019

Codecov Report

Merging #711 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
+ Coverage   94.01%   94.17%   +0.16%     
==========================================
  Files          32       32              
  Lines        5548     5548              
==========================================
+ Hits         5216     5225       +9     
+ Misses        332      323       -9
Impacted Files Coverage Δ
databricks/koalas/namespace.py 93.72% <0%> (+3.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b62fcc...ea4425e. Read the comment docs.

@softagram-bot
Copy link

Softagram Impact Report for pull/711 (head commit: ea4425e)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Impact Report explained. Give feedback on this report to support@softagram.com

@itholic
Copy link
Contributor Author

itholic commented Aug 29, 2019

@HyukjinKwon I've fixed them. Thanks for comment !

@HyukjinKwon HyukjinKwon merged commit 8360c58 into databricks:master Aug 29, 2019
@itholic itholic deleted the add_test_namespace branch September 6, 2019 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants