Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IndexOpsMixin.all/any. #652

Merged
merged 1 commit into from
Aug 19, 2019
Merged

Fix IndexOpsMixin.all/any. #652

merged 1 commit into from
Aug 19, 2019

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Aug 16, 2019

This PR fixes IndexOpsMixin.all() and any() to work the chain of operations, e.g.,:

>>> (ks.Series([1,2,3]) % 2 == 0).all()

This fails with the following error.

Traceback (most recent call last):
  File "/Users/ueshin/workspace/databricks-koalas/miniconda/envs/databricks-koalas_3.6/lib/python3.6/site-packages/pyspark/sql/utils.py", line 63, in deco
    return f(*a, **kw)
  File "/Users/ueshin/workspace/databricks-koalas/miniconda/envs/databricks-koalas_3.6/lib/python3.6/site-packages/py4j/protocol.py", line 328, in get_return_value
    format(target_id, ".", name), value)
py4j.protocol.Py4JJavaError: An error occurred while calling o143.select.
: org.apache.spark.sql.AnalysisException: Resolved attribute(s) 0#14L missing from ((0 % 2) = 0)#22 in operator !Aggregate [min(coalesce(cast(((0#14L % cast(2 as bigint)) = cast(0 as bigint)) as boolean), true)) AS min(coalesce(CAST(((0 % 2) = 0) AS BOOLEAN), true))#25].;;
!Aggregate [min(coalesce(cast(((0#14L % cast(2 as bigint)) = cast(0 as bigint)) as boolean), true)) AS min(coalesce(CAST(((0 % 2) = 0) AS BOOLEAN), true))#25]
+- Project [((0#14L % cast(2 as bigint)) = cast(0 as bigint)) AS ((0 % 2) = 0)#22]
   +- LogicalRDD [__index_level_0__#13L, 0#14L], false

@softagram-bot
Copy link

Softagram Impact Report for pull/652 (head commit: ce1ffca)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Give feedback on this report to [email protected]

@codecov-io
Copy link

codecov-io commented Aug 16, 2019

Codecov Report

Merging #652 into master will increase coverage by 1.86%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
+ Coverage   91.38%   93.24%   +1.86%     
==========================================
  Files          32       32              
  Lines        5267     5267              
==========================================
+ Hits         4813     4911      +98     
+ Misses        454      356      -98
Impacted Files Coverage Δ
databricks/koalas/base.py 92.07% <100%> (ø) ⬆️
databricks/koalas/internal.py 96.66% <0%> (+0.55%) ⬆️
databricks/conftest.py 97.67% <0%> (+4.65%) ⬆️
databricks/koalas/__init__.py 84.61% <0%> (+7.69%) ⬆️
databricks/koalas/usage_logging/usage_logger.py 100% <0%> (+50%) ⬆️
databricks/koalas/usage_logging/__init__.py 97.22% <0%> (+74.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0f1859...ce1ffca. Read the comment docs.

@ueshin ueshin requested a review from HyukjinKwon August 16, 2019 22:26
@HyukjinKwon HyukjinKwon merged commit 73a2854 into databricks:master Aug 19, 2019
@ueshin ueshin deleted the all_any branch August 19, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants