Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groupby.idxmax and Groupby.idxmin #649

Merged
merged 10 commits into from
Aug 22, 2019
Merged

Groupby.idxmax and Groupby.idxmin #649

merged 10 commits into from
Aug 22, 2019

Conversation

RainFung
Copy link
Contributor

Now only support one-level index

@codecov-io
Copy link

codecov-io commented Aug 15, 2019

Codecov Report

Merging #649 into master will decrease coverage by 2.06%.
The diff coverage is 95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #649      +/-   ##
==========================================
- Coverage   93.46%   91.39%   -2.07%     
==========================================
  Files          32       32              
  Lines        5324     5358      +34     
==========================================
- Hits         4976     4897      -79     
- Misses        348      461     +113
Impacted Files Coverage Δ
databricks/koalas/missing/groupby.py 100% <ø> (ø) ⬆️
databricks/koalas/groupby.py 87.65% <95%> (+0.73%) ⬆️
databricks/koalas/usage_logging/__init__.py 23.14% <0%> (-74.08%) ⬇️
databricks/koalas/usage_logging/usage_logger.py 50% <0%> (-50%) ⬇️
databricks/koalas/__init__.py 74.35% <0%> (-10.26%) ⬇️
databricks/conftest.py 90.69% <0%> (-6.98%) ⬇️
databricks/koalas/frame.py 93.78% <0%> (-0.76%) ⬇️
databricks/koalas/internal.py 95.71% <0%> (-0.48%) ⬇️
databricks/koalas/plot.py 93.7% <0%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea61ad9...0918ea9. Read the comment docs.

@RainFung
Copy link
Contributor Author

wait to be code reviewed.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine otherwise

@RainFung
Copy link
Contributor Author

I do nothing with groupby.rank why i failed in groupby.rank. Can you help me check it?

@softagram-bot
Copy link

Softagram Impact Report for pull/649 (head commit: c5af9a9)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Give feedback on this report to [email protected]

@HyukjinKwon HyukjinKwon merged commit 1eb7527 into databricks:master Aug 22, 2019
@RainFung RainFung deleted the idxmax_idxmin branch August 22, 2019 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants