Skip to content

Make SeriesType, DataFrameType, and ScalarType hold the dtypes as well. #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 29, 2021

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Mar 26, 2021

After the return type inference, SeriesType, DataFrameType, and ScalarType hold the dtypes as well as Spark DataTypes.

@ueshin ueshin requested a review from xinrong-meng March 26, 2021 23:09
@codecov-io
Copy link

codecov-io commented Mar 27, 2021

Codecov Report

Merging #2123 (3ad837f) into master (ed0bd49) will increase coverage by 0.00%.
The diff coverage is 89.74%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2123   +/-   ##
=======================================
  Coverage   95.37%   95.37%           
=======================================
  Files          60       60           
  Lines       13587    13591    +4     
=======================================
+ Hits        12958    12962    +4     
  Misses        629      629           
Impacted Files Coverage Δ
databricks/koalas/typedef/typehints.py 95.40% <86.36%> (+0.58%) ⬆️
databricks/koalas/groupby.py 94.31% <87.50%> (-0.12%) ⬇️
databricks/koalas/accessors.py 93.50% <100.00%> (+0.03%) ⬆️
databricks/koalas/frame.py 96.52% <100.00%> (+<0.01%) ⬆️
databricks/koalas/series.py 96.92% <100.00%> (ø)
databricks/koalas/utils.py 95.66% <0.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed0bd49...3ad837f. Read the comment docs.

@xinrong-meng
Copy link
Contributor

Looks great! Thank you!

@xinrong-meng xinrong-meng self-requested a review March 29, 2021 16:43
@ueshin
Copy link
Collaborator Author

ueshin commented Mar 29, 2021

Thanks! merging.

@ueshin ueshin merged commit c9e4791 into databricks:master Mar 29, 2021
@ueshin ueshin deleted the infer_return_type branch March 29, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants