-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DatetimeIndex.indexer_between_time() #2104
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2104 +/- ##
==========================================
- Coverage 95.21% 95.16% -0.06%
==========================================
Files 60 60
Lines 13460 13459 -1
==========================================
- Hits 12816 12808 -8
- Misses 644 651 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending tests.
The test result looks weird https://github.com/databricks/koalas/pull/2104/checks?check_run_id=2144103456. |
Thanks! merging. |
Thanks, @ueshin ! |
Implement DatetimeIndex.indexer_between_time()