-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DatetimeIndex.round(), DatetimeIndex.floor(), and DatetimeIndex.ceil() #2082
Implement DatetimeIndex.round(), DatetimeIndex.floor(), and DatetimeIndex.ceil() #2082
Conversation
xinrong-meng
commented
Mar 4, 2021
•
edited
Loading
edited
Codecov Report
@@ Coverage Diff @@
## master #2082 +/- ##
==========================================
- Coverage 95.27% 89.76% -5.52%
==========================================
Files 57 57
Lines 13196 13107 -89
==========================================
- Hits 12573 11765 -808
- Misses 623 1342 +719
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM.
# Methods | ||
def ceil(self, freq, *args, **kwargs) -> "DatetimeIndex": | ||
""" | ||
Perform floor operation on the data to the specified freq. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: floor -> ceil ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks! merging. |
Thank you! |