Add properties for DatetimeIndex #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinrong-meng
commented
Mar 2, 2021
| hour = _unsupported_property("hour", cls="DatetimeIndex") | ||
| minute = _unsupported_property("minute", cls="DatetimeIndex") | ||
| second = _unsupported_property("second", cls="DatetimeIndex") | ||
| microsecond = _unsupported_property("microsecond", cls="DatetimeIndex") | ||
| nanosecond = _unsupported_property("nanosecond", cls="DatetimeIndex") |
There was a problem hiding this comment.
Properties that are still missing would be implemented in follow-up PRs.
We don't implement them in datetimelike properties of the Series values, either.
Codecov Report
@@ Coverage Diff @@
## master #2074 +/- ##
==========================================
- Coverage 94.68% 93.89% -0.79%
==========================================
Files 55 55
Lines 11747 11802 +55
==========================================
- Hits 11123 11082 -41
- Misses 624 720 +96
Continue to review full report at Codecov.
|
ueshin
reviewed
Mar 2, 2021
Sounds good! Updated. |
ueshin
reviewed
Mar 2, 2021
|
Merged! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is proposed to add properties for DatetimeIndex. The added properties follow datetimelike properties of the Series values.