-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Int64Index, Float64Index, DatetimeIndex. #2025
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2025 +/- ##
==========================================
+ Coverage 94.61% 94.64% +0.03%
==========================================
Files 50 54 +4
Lines 11263 11393 +130
==========================================
+ Hits 10656 10783 +127
- Misses 607 610 +3
Continue to review full report at Codecov.
|
|
||
pass | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I ask for the reason why we don't support UInt64Index as https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.UInt64Index.html?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because Koalas doesn't support unsigned types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! Thanks!
return self.spark_frame.select(self.spark_column_for(label)).columns[0] | ||
|
||
def spark_column_for(self, label: Tuple): | ||
def spark_column_for(self, label: Tuple) -> spark.Column: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactoring!
It might be helpful we add some code examples in the PR description to explain what changes are introduced by this PR, for example, Before:
After:
|
LGTM! Thank you for doing this! |
Adds
Int64Index
,Float64Index
, andDatetimeIndex
as a placeholder.We should still add specific attributes and methods in the following PRs.
Before:
After: