Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ddof parameter for std and var. #1986

Merged
merged 1 commit into from
Dec 24, 2020
Merged

Support ddof parameter for std and var. #1986

merged 1 commit into from
Dec 24, 2020

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Dec 24, 2020

Supports ddof parameter for Frame.std and var.

@ueshin ueshin requested a review from HyukjinKwon December 24, 2020 02:04
@codecov-io
Copy link

codecov-io commented Dec 24, 2020 •
edited
Loading

Codecov Report

Merging #1986 (d26a5dd) into master (5c44ecc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1986   +/-   ##
=======================================
  Coverage   94.54%   94.55%           
=======================================
  Files          50       50           
  Lines       10934    10939    +5     
=======================================
+ Hits        10338    10343    +5     
  Misses        596      596
Impacted Files Coverage Δ
databricks/koalas/frame.py 96.73% <100.00%> (-0.01%) ⬇️
databricks/koalas/generic.py 92.61% <100.00%> (+0.10%) ⬆️
databricks/koalas/series.py 96.75% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c44ecc...d26a5dd. Read the comment docs.

@HyukjinKwon HyukjinKwon merged commit 5f27857 into databricks:master Dec 24, 2020
@ueshin ueshin deleted the ddof branch December 24, 2020 04:26
itholic
itholic reviewed Dec 28, 2020
View reviewed changes
Copy link
Contributor

@itholic itholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itholic itholic itholic left review comments

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ueshin @codecov-io @HyukjinKwon @itholic