Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cumsum and cumprod. #1982

Merged
merged 1 commit into from
Dec 23, 2020
Merged

Fix cumsum and cumprod. #1982

merged 1 commit into from
Dec 23, 2020

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Dec 23, 2020

Fixes DataFrame/Series/GroupBy.cumsum and cumprod.

@codecov-io
Copy link

codecov-io commented Dec 23, 2020

Codecov Report

Merging #1982 (b17d0da) into master (dd9661f) will increase coverage by 0.00%.
The diff coverage is 91.30%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1982   +/-   ##
=======================================
  Coverage   94.57%   94.57%           
=======================================
  Files          50       50           
  Lines       10946    10952    +6     
=======================================
+ Hits        10352    10358    +6     
  Misses        594      594           
Impacted Files Coverage Δ
databricks/koalas/groupby.py 91.58% <ø> (ø)
databricks/koalas/series.py 96.93% <89.47%> (+0.01%) ⬆️
databricks/koalas/generic.py 92.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd9661f...b17d0da. Read the comment docs.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyukjinKwon HyukjinKwon merged commit f9465aa into databricks:master Dec 23, 2020
@ueshin ueshin deleted the cumprod branch December 23, 2020 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants