Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add min_count parameter for Frame.sum. #1978

Merged
merged 2 commits into from
Dec 22, 2020
Merged

Add min_count parameter for Frame.sum. #1978

merged 2 commits into from
Dec 22, 2020

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Dec 21, 2020

Adds min_count parameter for Frame.sum.

@codecov-io
Copy link

codecov-io commented Dec 22, 2020 •
edited
Loading

Codecov Report

Merging #1978 (f4a976e) into master (c973195) will decrease coverage by 0.99%.
The diff coverage is 96.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1978      +/-   ##
==========================================
- Coverage   94.56%   93.57%   -1.00%     
==========================================
  Files          50       50              
  Lines       10935    10946      +11     
==========================================
- Hits        10341    10243      -98     
- Misses        594      703     +109
Impacted Files Coverage Δ
databricks/koalas/frame.py 96.75% <92.85%> (-0.04%) ⬇️
databricks/koalas/generic.py 91.89% <100.00%> (-0.24%) ⬇️
databricks/koalas/series.py 96.91% <100.00%> (+<0.01%) ⬆️
databricks/koalas/testing/utils.py 80.71% <100.00%> (+0.19%) ⬆️
databricks/koalas/usage_logging/__init__.py 24.78% <0.00%> (-67.53%) ⬇️
databricks/koalas/usage_logging/usage_logger.py 47.82% <0.00%> (-52.18%) ⬇️
databricks/koalas/__init__.py 81.25% <0.00%> (-9.38%) ⬇️
databricks/conftest.py 94.20% <0.00%> (-5.80%) ⬇️
databricks/koalas/utils.py 93.59% <0.00%> (-1.78%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c973195...f4a976e. Read the comment docs.

itholic
itholic approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@itholic itholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. LGTM

databricks/koalas/frame.py
Comment on lines +635 to +636
spark_column = self._internal.spark_column_for(label)
spark_type = self._internal.spark_type_for(label)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@xinrong-meng
Copy link
Contributor

Are we going to add test cases in a separate pr?

@ueshin ueshin marked this pull request as draft December 22, 2020 19:45
@ueshin
Copy link
Collaborator Author

ueshin commented Dec 22, 2020 •
edited
Loading

I'll fix some corner cases and add tests soon.

@ueshin ueshin marked this pull request as ready for review December 22, 2020 20:48
@ueshin ueshin requested a review from xinrong-meng December 22, 2020 20:55
@xinrong-meng
Copy link
Contributor

Great! LGTM!

@ueshin
Copy link
Collaborator Author

ueshin commented Dec 22, 2020

Thanks! merging.

@ueshin ueshin merged commit dd9661f into databricks:master Dec 22, 2020
@ueshin ueshin deleted the min_count branch December 22, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itholic itholic itholic approved these changes

@HyukjinKwon HyukjinKwon Awaiting requested review from HyukjinKwon

@xinrong-meng xinrong-meng Awaiting requested review from xinrong-meng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ueshin @codecov-io @xinrong-meng @itholic