-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stat functions with no numeric columns. #1967
Fix stat functions with no numeric columns. #1967
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1967 +/- ##
=======================================
Coverage 94.60% 94.60%
=======================================
Files 49 49
Lines 10890 10890
=======================================
+ Hits 10302 10303 +1
+ Misses 588 587 -1
Continue to review full report at Codecov.
|
@@ -27,35 +27,46 @@ | |||
|
|||
|
|||
class StatsTest(ReusedSQLTestCase, SQLTestUtils): | |||
def _test_stat_functions(self, pdf, kdf): | |||
def _test_stat_functions(self, pdf_or_pser, kdf_or_kser): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great refactoring!
LGTM! Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Some statistic functions fail if there are no numeric columns.
The functions which allow non-numeric columns by default are:
count
min
max