Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DataFrame.replace with NaN/None values #1907 #1962

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

LucasG0
Copy link
Contributor

@LucasG0 LucasG0 commented Dec 10, 2020

Hi, this PR would close #1907.

@codecov-io
Copy link

Codecov Report

Merging #1962 (7acdba6) into master (02133a8) will decrease coverage by 3.57%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1962      +/-   ##
==========================================
- Coverage   94.64%   91.06%   -3.58%     
==========================================
  Files          49       49              
  Lines       10861    10760     -101     
==========================================
- Hits        10279     9799     -480     
- Misses        582      961     +379     
Impacted Files Coverage Δ
databricks/koalas/series.py 95.71% <100.00%> (-1.17%) ⬇️
...bricks/koalas/tests/plot/test_frame_plot_plotly.py 26.58% <0.00%> (-73.42%) ⬇️
databricks/koalas/usage_logging/__init__.py 25.66% <0.00%> (-66.65%) ⬇️
...ricks/koalas/tests/plot/test_series_plot_plotly.py 37.50% <0.00%> (-58.80%) ⬇️
databricks/koalas/usage_logging/usage_logger.py 47.82% <0.00%> (-52.18%) ⬇️
databricks/koalas/__init__.py 73.43% <0.00%> (-17.19%) ⬇️
databricks/conftest.py 88.13% <0.00%> (-11.87%) ⬇️
databricks/koalas/spark/functions.py 88.88% <0.00%> (-7.41%) ⬇️
databricks/koalas/accessors.py 86.43% <0.00%> (-7.04%) ⬇️
databricks/koalas/namespace.py 78.12% <0.00%> (-6.08%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02133a8...7acdba6. Read the comment docs.

Copy link
Contributor

@itholic itholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, looks pretty fine to me.

databricks/koalas/series.py Show resolved Hide resolved
databricks/koalas/series.py Show resolved Hide resolved
@itholic
Copy link
Contributor

itholic commented Dec 15, 2020

Seems good to me. Let's wait a while for reviews from others :)

@HyukjinKwon
Copy link
Member

Thanks @LucasG0. Merged.

@HyukjinKwon HyukjinKwon merged commit fab671c into databricks:master Dec 16, 2020
@itholic
Copy link
Contributor

itholic commented Dec 16, 2020

Thanks, @LucasG0 !! :D

@LucasG0
Copy link
Contributor Author

LucasG0 commented Dec 16, 2020

Thanks. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function "replace" Case
4 participants