Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unneeded reset_index in DataFrameGroupBy.describe. #1951

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Dec 3, 2020

DataFrameGroupBy.describe uses reset_index() internally, but we can avoid using it and so unnecessary default index attachment.

@codecov-io
Copy link

Codecov Report

Merging #1951 (1e6f3ea) into master (138c7b8) will decrease coverage by 3.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1951      +/-   ##
==========================================
- Coverage   94.64%   91.19%   -3.46%     
==========================================
  Files          49       49              
  Lines       10818    10713     -105     
==========================================
- Hits        10239     9770     -469     
- Misses        579      943     +364     
Impacted Files Coverage Δ
databricks/koalas/groupby.py 91.35% <100.00%> (-0.07%) ⬇️
...bricks/koalas/tests/plot/test_frame_plot_plotly.py 26.58% <0.00%> (-73.42%) ⬇️
databricks/koalas/usage_logging/__init__.py 25.66% <0.00%> (-66.65%) ⬇️
...ricks/koalas/tests/plot/test_series_plot_plotly.py 37.50% <0.00%> (-58.80%) ⬇️
databricks/koalas/usage_logging/usage_logger.py 47.82% <0.00%> (-52.18%) ⬇️
databricks/koalas/__init__.py 68.75% <0.00%> (-21.88%) ⬇️
databricks/conftest.py 89.83% <0.00%> (-10.17%) ⬇️
databricks/koalas/spark/functions.py 88.88% <0.00%> (-7.41%) ⬇️
databricks/koalas/accessors.py 86.43% <0.00%> (-7.04%) ⬇️
databricks/koalas/namespace.py 78.17% <0.00%> (-6.07%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 138c7b8...1e6f3ea. Read the comment docs.

@xinrong-meng
Copy link
Contributor

Make senses! Thank you!

@ueshin
Copy link
Collaborator Author

ueshin commented Dec 4, 2020

Thanks! merging.

@ueshin ueshin merged commit 76645a4 into databricks:master Dec 4, 2020
@ueshin ueshin deleted the groupby_describe branch December 4, 2020 01:06
@itholic
Copy link
Contributor

itholic commented Dec 8, 2020

Nice fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants