Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the missing DataFrame.swaplevel #1928

Merged
merged 16 commits into from
Nov 25, 2020

Conversation

xinrong-meng
Copy link
Contributor

No description provided.

@xinrong-meng xinrong-meng marked this pull request as ready for review November 24, 2020 18:07
Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, I guess we can rewrite Series.swaplevel using DataFrame.swaplevel now?

databricks/koalas/frame.py Outdated Show resolved Hide resolved
databricks/koalas/frame.py Outdated Show resolved Hide resolved
databricks/koalas/frame.py Outdated Show resolved Hide resolved
@@ -1270,7 +1270,7 @@ def reset_index(
else:
return kdf

def to_frame(self, name: Union[Any, Tuple] = None) -> SparkDataFrame:
def to_frame(self, name: Union[Any, Tuple] = None) -> DataFrame:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correcting return type.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending tests.

@ueshin
Copy link
Collaborator

ueshin commented Nov 25, 2020

Thanks! merging.

@ueshin ueshin merged commit 077832b into databricks:master Nov 25, 2020
@itholic
Copy link
Contributor

itholic commented Nov 25, 2020

Cool !! Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants