Fix first/last_valid_index to support empty column DataFrame. #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1923 +/- ##
==========================================
- Coverage 94.15% 94.14% -0.01%
==========================================
Files 41 41
Lines 10007 10011 +4
==========================================
+ Hits 9422 9425 +3
- Misses 585 586 +1
Continue to review full report at Codecov.
|
| @@ -1687,7 +1688,7 @@ def bool(self) -> bool: | |||
| raise TypeError("bool() expects DataFrame or Series; however, " "got [%s]" % (self,)) | |||
| return df.head(2)._to_internal_pandas().bool() | |||
|
|
|||
| def first_valid_index(self) -> Union[Any, Tuple[Any, ...]]: | |||
| def first_valid_index(self) -> Optional[Union[Any, Tuple[Any, ...]]]: | |||
| """ | |||
| Retrieves the index of the first valid value. | |||
|
|
|||
There was a problem hiding this comment.
Shall we modify Returns in docstrings by including None?
|
|
||
| def last_valid_index(self) -> Union[Any, Tuple[Any, ...]]: | ||
| def last_valid_index(self) -> Optional[Union[Any, Tuple[Any, ...]]]: | ||
| """ | ||
| Return index for last non-NA/null value. | ||
|
|
| @@ -1863,25 +1868,32 @@ def last_valid_index(self) -> Union[Any, Tuple[Any, ...]]: | |||
| >>> s.last_valid_index() # doctest: +SKIP | |||
| ('cow', 'weight') | |||
| """ | |||
| sdf = self._internal.spark_frame | |||
| if LooseVersion(pyspark.__version__) < LooseVersion("3.0"): | |||
There was a problem hiding this comment.
That's better than specifying in docstrings only!
|
Other than two docstring improvements, LGTM! |
|
Thanks! merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
first/last_valid_indexto support empty column DataFrame.E.g.,:
, which should return
None:This PR also includes: