Implement DataFrame/Series reindex_like #1880
Conversation
|
Nice work, @LucasG0 ! |
Codecov Report
@@ Coverage Diff @@
## master #1880 +/- ##
=======================================
Coverage 94.19% 94.19%
=======================================
Files 40 40
Lines 9867 9939 +72
=======================================
+ Hits 9294 9362 +68
- Misses 573 577 +4
Continue to review full report at Codecov.
|
|
Despite Codecov report, coverage seems actually ok. |
| ---------- | ||
| other : Series or DataFrame | ||
| Its row and column indices are used to define the new indices | ||
| of this object. |
There was a problem hiding this comment.
Anyway, maybe pandas has copy parameter for Series.reindex_like, too ??
Even if it doesn't really do any meaningful work, how about adding it for compatibility with pandas?
There was a problem hiding this comment.
Yes pandas has copy parameter for Series.reindex_like. If we add it, we need to update Series.reindex too, which does not support copy parameter either.
Should I do the change ?
There was a problem hiding this comment.
Hmm... okay let's keep it as it is for now and discuss separately later.
Thanks for the opinion!
|
awesome, thanks @LucasG0 for working on this. |
|
Great, @LucasG0 ! |
|
Thanks! merging. |
Hi, this PR implements both
DataFrame.reindex_likeandSeries.reindex_like.I did not add a test about reindexing MultiIndex columns on single Index columns because it is currently not supported in koalas. Also, as for
DataFrame.reindex, there is no test for reindexing single Index columns/index on MultiIndex columns/index, as it is not supported in pandas.