Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SPARK_INDEX_NAME_FORMAT in combine_frames to avoid ambiguity. #1650

Merged
merged 2 commits into from
Jul 15, 2020

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Jul 14, 2020

Use SPARK_INDEX_NAME_FORMAT in utils.combine_frames to avoid ambiguity.

>>> ks.options.compute.ops_on_diff_frames = True
>>> kdf = ks.DataFrame({"a": [1, 2, 3], "Koalas": [0, 1, 2]}).set_index("Koalas", drop=False)
>>> kdf.index.name = None
>>> kdf["NEW"] = ks.Series([100, 200, 300])
>>> kdf
Traceback (most recent call last):
...
pyspark.sql.utils.AnalysisException: Reference 'Koalas' is ambiguous, could be: Koalas, Koalas.;

Related to #1647 as well.

@ueshin ueshin requested a review from HyukjinKwon July 14, 2020 01:48
@itholic
Copy link
Contributor

itholic commented Jul 14, 2020

LGTM

@HyukjinKwon HyukjinKwon merged commit 156a4f5 into databricks:master Jul 15, 2020
@ueshin ueshin deleted the combine_frames branch July 15, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants