Clean up InternalFrame and around anchor. #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Jun 21, 2020
itholic
reviewed
Jun 21, 2020
| @@ -2829,7 +2818,7 @@ def transpose(self, *args, **kwargs): | |||
| 2 3 | |||
| Name: 0, dtype: int64 | |||
| """ | |||
| return first_series(DataFrame(self._internal.copy(spark_column=None))) | |||
| return self.copy() | |||
|
LGTM |
|
@ueshin Feel free to merge. I will not merge in case you have some more things to push here. |
|
I'd merge this now. I'll have some more things to do but they should be in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up
InternalFrameto removespark_columnand fix around it, also add some utility methods.