-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support pd.DataFrame and pd.Series in return type hints #1577
Support pd.DataFrame and pd.Series in return type hints #1577
Conversation
a36fa8c
to
7a70174
Compare
Codecov Report
@@ Coverage Diff @@
## master #1577 +/- ##
==========================================
+ Coverage 94.55% 94.57% +0.01%
==========================================
Files 38 38
Lines 8766 8792 +26
==========================================
+ Hits 8289 8315 +26
Misses 477 477
Continue to review full report at Codecov.
|
fde1cf2
to
756c5c8
Compare
f0a329f
to
fb1a8c0
Compare
aab1c1b
to
3ad4732
Compare
3ad4732
to
be9a840
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks! merging. |
This PR proposes to support the type hints with pandas Series and pandas DataFrame directly.
Note that:
The type hints with Pandas only works with Python 3.7+.
The previous way with Koalas DataFrame type hint will still work but will be deprecated once we deprecate Python 3.5 and 3.6.