Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Series.item to run a Spark job once #1518

Merged
merged 3 commits into from
May 21, 2020

Conversation

itholic
Copy link
Contributor

@itholic itholic commented May 20, 2020

According to the comment #1502 (comment), fixed Series.item to run a Spark job not twice, once.

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2020

Codecov Report

Merging #1518 into master will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1518      +/-   ##
==========================================
+ Coverage   93.87%   94.02%   +0.15%     
==========================================
  Files          36       36              
  Lines        8469     8466       -3     
==========================================
+ Hits         7950     7960      +10     
+ Misses        519      506      -13     
Impacted Files Coverage Δ
databricks/koalas/series.py 97.71% <100.00%> (-0.01%) ⬇️
databricks/koalas/frame.py 95.59% <0.00%> (+0.19%) ⬆️
databricks/koalas/generic.py 97.02% <0.00%> (+0.37%) ⬆️
databricks/koalas/utils.py 96.63% <0.00%> (+2.40%) ⬆️
databricks/koalas/__init__.py 92.30% <0.00%> (+5.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb4d21c...3b9b152. Read the comment docs.

Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM.

@HyukjinKwon HyukjinKwon merged commit bdd34ed into databricks:master May 21, 2020
@itholic itholic deleted the fix_s_item branch May 29, 2020 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants