-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Series.div when div/floordiv np.inf by zero #1463
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1463 +/- ##
==========================================
+ Coverage 93.75% 93.93% +0.18%
==========================================
Files 36 36
Lines 8386 8445 +59
==========================================
+ Hits 7862 7933 +71
+ Misses 524 512 -12
Continue to review full report at Codecov.
|
Could someone review this PR when available to finish #1397 ? |
@HyukjinKwon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise.
There is an incompatible hehaviour with pandas when divide
np.inf
by 0This PR fixed it.