Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot-fixing the lack of keyword argument 'deep' for DataFrame.copy() #1423

Merged
merged 4 commits into from
Apr 16, 2020

Conversation

itholic
Copy link
Contributor

@itholic itholic commented Apr 15, 2020

Resolves #1422

Adding a dummy keyword argument deep which is doing nothing for DataFrame.copy(), since we doesn't support keyword deep for the DataFrame.copy().

@ueshin
Copy link
Collaborator

ueshin commented Apr 15, 2020

SGTM.
Shall we add it for Series and Index as well?
Also, could you add parameter sections in each function docstring to describe the argument is a dummy?

@itholic
Copy link
Contributor Author

itholic commented Apr 15, 2020

@ueshin

Thanks for the comment. I think it is better to do that, either.

Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending tests.

@codecov-io
Copy link

codecov-io commented Apr 15, 2020

Codecov Report

Merging #1423 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1423   +/-   ##
=======================================
  Coverage   95.13%   95.13%           
=======================================
  Files          34       34           
  Lines        7958     7958           
=======================================
  Hits         7571     7571           
  Misses        387      387           
Impacted Files Coverage Δ
databricks/koalas/frame.py 96.61% <100.00%> (ø)
databricks/koalas/indexes.py 97.06% <100.00%> (ø)
databricks/koalas/series.py 96.92% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd500d2...dfddc3d. Read the comment docs.

@HyukjinKwon HyukjinKwon merged commit 42e6eff into databricks:master Apr 16, 2020
@itholic itholic deleted the deep_copy branch April 21, 2020 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: copy() got an unexpected keyword argument 'deep'
4 participants