Add documentation about non-Koalas APIs #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1420 +/- ##
=======================================
Coverage 95.13% 95.13%
=======================================
Files 34 34
Lines 7958 7958
=======================================
Hits 7571 7571
Misses 387 387 Continue to review full report at Codecov.
|
HyukjinKwon
reviewed
Apr 14, 2020
HyukjinKwon
reviewed
Apr 14, 2020
HyukjinKwon
approved these changes
Apr 14, 2020
There was a problem hiding this comment.
LGTM except https://github.com/databricks/koalas/pull/1420/files#r408089980. Thanks for working on this.
HyukjinKwon
reviewed
Apr 15, 2020
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1414
I have added a preemptive guide to non-Koalas APIs to
best practeces.Please check.